add regression test for WithDocumentationMode #17803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviews please: @dotnet/roslyn-compiler |
jcouv
reviewed
Mar 13, 2017
| Assert.Equal(1, po2.Features.Count); | ||
| } | ||
|
|
||
|
|
|
When was the problem fixed? |
jaredpar
reviewed
Mar 14, 2017
| var po = new CSharpParseOptions().WithFeatures(new[] { new KeyValuePair<string, string>("IOperation", "true") }); | ||
| Assert.Equal(1, po.Features.Count); | ||
| var po2 = po.WithDocumentationMode(DocumentationMode.Diagnose); | ||
| Assert.Equal(1, po2.Features.Count); |
There was a problem hiding this comment.
We should make sure the values match while we're here and adding a test.
TyOverby
force-pushed
the
15358-regression
branch
from
f6905aa to
4823ba2
Compare
TyOverby
force-pushed
the
15358-regression
branch
from
4823ba2 to
29ff190
Compare
AlekseyTs
reviewed
Mar 14, 2017
| var kvp = new KeyValuePair<string, string>("IOperation", "true"); | ||
| var po = new CSharpParseOptions().WithFeatures(new[] { kvp }); | ||
| Assert.Equal(po.Features.AsSingleton(), kvp); | ||
| var po2 = po.WithDocumentationMode(DocumentationMode.Diagnose); |
There was a problem hiding this comment.
var po2 = po.WithDocumentationMode(DocumentationMode.Diagnose); [](start = 12, length = 63)
I think it would be good to assert DocumentationMode before and after. What if the WithDocumentationMode method does nothing? #Closed
There was a problem hiding this comment.
This is tested in the next test in the file.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15358